Lines of Code
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 194 (100.0%) | 1702 (100.0%) | 8.7 |
| perost | 81 (41.8%) | 1420 (83.4%) | 17.5 |
| adrpo | 16 (8.2%) | 208 (12.2%) | 13.0 |
| sjoelund.se | 49 (25.3%) | 50 (2.9%) | 1.0 |
| mahge930 | 1 (0.5%) | 24 (1.4%) | 24.0 |
| alash325 | 47 (24.2%) | 0 (0.0%) | 0.0 |
- expandable,streams,records ,and redeclare directory from testsuite are moved to ./flattening/modelica plus updated the corresponding Make file
0 lines of code changed in 47 files:
- Fixed svn:eol-style
2 lines of code changed in 2 files:
- Fixing the testsuite, again...
1 lines of code changed in 1 file:
- Added error message when trying to redeclare nonexisting element.
47 lines of code changed in 4 files:
- Implemented a new template based expression dumping.
- Updated test suite.
2 lines of code changed in 1 file:
- Changed the Dependency+SCode+Inst calls everywhere to:
+ CevalScript.runFrontEnd(...), which does more error-checking
- Removed Inst.{instantiate,instProgram} as they are not needed (they were used to inst the last class of the program; which can be performed by asking for the last class of the program and instantiating that)
11 lines of code changed in 11 files:
+ The test-suite makefile now contain DEPENDENCIES. This are the files that are needed for the test cases.
+ "make clean" or (make -j clean) will clean the test-suite. i.e. all files that are not listed as DEPENDENCIES will be cleaned.
For OMDEV/MINGW ppl (linux already has partest)
+ "make threaded" will clean and then run the test-suite with 5 threads (my pc has 4 cores so :) ). (or just use "make -jN")
- 'msl31simulation.log' and 'msl31mediasimulation.log' still give problems with multiple threads. Very strange problem since the
output matches exactly with the expected but for some reason it is compared with outputs from another file. But For now this might help a bit.
Normal test-suite operation is not affected in anyway as far as I can tell. (Just some additions)
24 lines of code changed in 1 file:
- Added rule Real(i1:i2) => Real(i1):Real(i2)
2 lines of code changed in 1 file:
- Changed the unbalanced connector error to be a warning.
3 lines of code changed in 1 file:
- Set svn-eol-style on a few files
34 lines of code changed in 34 files:
- Expected output
1 lines of code changed in 1 file:
- Removed check for redeclaration of protected elements, since it's actually
allowed.
- Implemented support for cardinality of connector arrays.
7 lines of code changed in 2 files:
HUGE update to SVN with *a lot* of changes: DO MAKE CLEAN!
==========================================================
- The DAE.ExpType is *no more*
- The BackendDAE.Type is *no more*
Both got replaced by DAE.Type!
- The DAE.ExpVar is *no more*
It got replaced by DAE.Var!
Now we have *ONLY ONE* type in the compiler: DAE.Type!
Just to know why I got this done:
BEFORE, the model HumMod took 6m51 seconds to instantiate
adrpo@ida-liu050 ~/dev/OpenModelica/doc/performance/benchmarks/tests
$ time /c/OpenModelica1.8.0-r10584/bin/omc instHumMod.mos > trace.txt 2>&1
real 6m51.354s
user 0m0.000s
sys 0m0.015s
AFTER, the model HumMod takes 47 seconds to instantiate
adrpo@ida-liu050 ~/dev/OpenModelica/doc/performance/benchmarks/tests
$ time ../../../../build/bin/omc instHumMod.mos > mytrace.txt 2>&1
real 0m47.248s
user 0m0.000s
sys 0m0.000s
Is about 8,74468085106383 times faster now.
Basically, before, we were doing DAE.T_*
-> DAE.ET_* translation for 6 minutes!
I started this work on Friday after the OpenModelica 1.8.0
got released, so for 4+ days of work I think the result is
quite OK.
Crash course into the new types (actually old ones from DAE.Type):
==================================================================
1. DAE.Type is not a tuple anymore, instead the optional path
became DAE.TypeSource which is a list of paths and is now
part of *all* the records in DAE.Type.
The needed types from DAE.ExpType got merged into DAE.Type:
DAE.ET_METATYPE -> DAE.T_METATYPE
DAE.ET_FUNCTION_REFERENCE_VAR -> DAE.T_FUNCTION_REFERENCE_VAR
DAE.ET_FUNCTION_REFERENCE_FUNC -> DAE.T_FUNCTION_REFERENCE_FUNC
Some DAE.Type types got split:
DAE.T_COMPLEX split into DAE.T_COMPLEX for types not extending
basic types and DAE.T_SUBTYPE_BASIC is now used for types
extending basic types.
Some DAE.Type types changed name:
DAE.T_NOTYPE -> DAE.T_UNKNOWN
Renamed also the meta-types a bit to make them more homogeneous.
Some DAE.ExpType are gone:
DAE.ET_OTHER is gone, use DAE.T_UNKNOWN instead!
Some DAE.Type types changed structure (besides the DAE.TypeSource addition):
(DAE.T_ARRAY(dim, ty), optPath) -> DAE.T_ARRAY(ty, list<dim>, list<Path>)
so we now have similar structure for DAE.T_ARRAY and the previous DAE.ET_ARRAY.
2. In cases, when matching:
Instead of | Use now:
-------------------------------------------------------
DAE.ET_INT() | DAE.T_INTEGER(source = _)
DAE.ET_REAL() | DAE.T_REAL(source = _)
DAE.ET_BOOL() | DAE.T_BOOL(source = _)
DAE.ET_STRING() | DAE.T_STRING(source = _)
DAE.ET_ENUMERATION(...) | DAE.T_ENUMERATION(...)
DAE.ET_COMPLEX(...) | DAE.T_COMPLEX(...)
DAE.ET_OTHER(...) | DAE.T_UNKNOWN(source = _)
DAE.ET_ARRAY(...) | DAE.T_ARRAY(...)
-------------------------------------------------------
3. When constructing values, in the then part or in right
hand side in equations:
Instead of | Use now:
-------------------------------------------------------
DAE.ET_INT() | DAE.T_INTEGER_DEFAULT
DAE.ET_REAL() | DAE.T_REAL_DEFAULT
DAE.ET_BOOL() | DAE.T_BOOL_DEFAULT
DAE.ET_STRING() | DAE.T_STRING_DEFAULT
DAE.ET_ENUMERATION(...) | DAE.T_ENUMERATION(...)
DAE.ET_COMPLEX(...) | DAE.T_COMPLEX(...)
DAE.ET_OTHER(...) | DAE.T_UNKNOWN(source = _)
DAE.ET_ARRAY(...) | DAE.T_ARRAY(...)
-------------------------------------------------------
4. Types.elabType got renamed to Types.simplifyType
and does some type simplification (instead of the
previous DAE.T_* -> DAE.ET_* translation).
Feel free to ask me anything if something is unclear.
The code can be further improved (we need better handling
of DAE.T_ARRAY that has several dimensions instead of one)
by getting rid of Types.simplifyType/Types.expTypetoTypesType,
but for now is good enough. Also, functionality for the old
DAE.ET_* handling from Expression*.mo can be merged with the
DAE.T_ handling from Types so we can get rid of duplicate
code too.
2 lines of code changed in 1 file:
- Changed instClassDecls to not filter out the class to instantiate, since this
causes problems when instantiating a top model.
- Added test cases to test the fix.
57 lines of code changed in 3 files:
- include the modifiers and dimensions in the dependency analysis in Inst.instElementList
- move annotation checking functions from DAEUtil to SCode.
- convert type of the Value in the binding if needed (to get rid of things like min = 0, instead of min = 0.0)
- in partial instantiation disregard parameters, instantiate only constants.
- rename the really bad name "subs" to restCref in Static.elabCrefSubs.
- clear errors when loadingFileInteractiveQualified API and parseFile API
- added vaporizing.mo test
- a LOT of tests have changed
- small fixes to tools/validatetest/validatetest.pl
15 lines of code changed in 7 files:
- Don't enter base classes that the lookup is coming from in SCodeLookup to
avoid infinite loops when extending a base class further down in the environment.
- When doing dependency analysis on an extends clause, remove it from the
environment so that we don't look it up in itself.
5 lines of code changed in 5 files:
- Added a flag to OMC, +std, to set the Modelica language version to use. API
calls setLanguageStandard and getLanguageStandard are also implemented for
this.
- The Modelica language version is now set automatically if a specific version
of the MSL is loaded, and gives a notification if the version has changed.
- Added new package RTOptsData, which contains data types and some functions
which can't be in RTOpts since RML doesn't allow mixing external and
non-external things.
- Turned on error messages for replaceable base classes if Modelica version is
at least 3.0.
- Turned on balance checking of connectors if Modelica version is at least 3.0.
- Updated test suite, and added a new test case redeclare/ReplaceableBaseClass.
32 lines of code changed in 4 files:
- chain the redeclares.
49 lines of code changed in 3 files:
- getting the testsuite closer to 100%
- more fixes are on the way for redeclares.
6 lines of code changed in 1 file:
Fix for bug #1605
- Report error for duplicate redeclarations in the same scope.
54 lines of code changed in 3 files:
- Fixed stack overflow for Modelica.Media.IdealGases.Common.SingleGasNasa, see
added comments in SCodeFlattenRedeclare for explanation of the fix.
- Added test case redeclare/RedeclareBaseClass1 and removed duplicate test
redeclare/RedeclareFunctionBug1432.
45 lines of code changed in 2 files:
- Removed a tab.
1 lines of code changed in 1 file:
- Translate Absyn.ConstrainClass into SCode.ConstrainClass in
translateAbsyn2SCode.
- Updated some redeclare test cases.
38 lines of code changed in 3 files:
Fixes for bugs: #1430, #1432
- moved printing functions from SCode to SCodeDump.
- some fixes to redeclares-as-element in SCodeFlattenRedeclare.mo
- fixes for handling derived classes (that do not extend from basic types)
to have the correct scope, not the scope of the base class (Inst.mo).
- added SCodeDump.mo
- added SCodeFlat.mo (not part of the compilation yet).
- added more tests for replaceable functions and for functions in derived packages that depend on a modified constant.
- added SCodeMod.mo to handle modifiers.
- some changes in SCodeHashTable.mo
- disabled SCodeFlattenExtends.mo for now.
136 lines of code changed in 4 files:
- Cleaned up elaboration of subscripts in Static.elabSubscriptDims.
- Corrected evaluation of subscripts in Static.elabSubscriptDims.
- Added test case mofiles/SubscriptEval.
- Corrected test case redeclare/Modification1.
2 lines of code changed in 1 file:
For bug #1430:
- Added test case for bug 1430.
63 lines of code changed in 2 files:
- Removed erroneous check for non-replaceable class definitions in Inst.
- Added test case redeclare/FinalRedeclareModifier2.
26 lines of code changed in 2 files:
- Added another test case for redeclare checks.
26 lines of code changed in 2 files:
- Check for protected or constant elements when handling redeclare.
53 lines of code changed in 4 files:
- Implemented checks for correct prefixes when redeclaring elements in
modifiers.
- Added test cases to test the new error messages.
79 lines of code changed in 4 files:
- Enabled SCodeFlatten by default.
- Updated the test suite to comply with SCodeFlatten.
7 lines of code changed in 1 file:
SCodeFlatten improvements:
- Redeclare improvements.
- Better recursive short class definition detection.
- More redeclare error messages.
- Reorganised the redeclare parts of SCodeFlatten by moving most of the code
that handles redeclares to SCodeFlattenRedeclare.
- Added some more redeclaration test cases.
53 lines of code changed in 3 files:
- Changed expected output of test case redeclare/Modification1 and moved it to
failing tests.
2 lines of code changed in 2 files:
- Added and corrected some redeclare test cases.
67 lines of code changed in 6 files:
- Fixed infinite loop in Inst.updateCompeltsMods for Media models.
- Added more redeclare test cases.
123 lines of code changed in 4 files:
- Added missing makefile.
0 lines of code changed in 1 file:
- Added new testcase directory 'redeclare' with some new redeclare tests.
- Moved some old redeclare tests from mofiles to the new directory.
627 lines of code changed in 19 files: